make fetchpo poqm aware and change argument handling to scale better
ClosedPublic
Actions

Authored by sitter on Apr 20 2017, 1:55 PM.

Details

Reviewers

apol

Commits

Summary

l10n.get now has a third argument for the poqm target, use it
changed option parsing to explicitly expect the output dirs, argument popping gets really shitty if you need to pop more than one
compressed help verbosity a bit by dropping excess option information

Repository

R572 releaseme

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

fetchpo.rb
56	Do we _always_ need to have an `output-poqm_dir`?
68–69	Same with `output_poqm_dir`?

check poqm_dir as well

sitter marked an inline comment as done.Apr 20 2017, 2:09 PM

sitter added inline comments.

fetchpo.rb
56	Releaseme does not know if it needs the dir until it actually looked at the templates. So as far as fetchpo is concerned I think it's safest to explicitly require one. If there are no actual qt translations it won't matter if you passed a useless argument. If there are, the lack of a directory to put them in is a problem however.

This revision is now accepted and ready to land.Apr 20 2017, 2:37 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			fetchpo.rb (33 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13642	46ff78b		Apr 20 2017, 1:55 PM	★	★
Diff 2	13643	46ff78b	check poqm_dir as well	Apr 20 2017, 2:09 PM	★	★
Diff 3	13649	46ff78b	R572:8a4bd4e430cab78cba4a1b70028859aaa48cc5d6	Apr 20 2017, 3:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bb338d86d4a8	968117f3a63d	46ff78ba7086	Harald Sitter	make fetchpo poqm aware and change argument handling to scale better (Show More…)	Apr 20 2017, 12:59 PM