Check to verify we have write permissions when saving profiles
ClosedPublic
Actions

Authored by hindenburg on Apr 20 2017, 2:04 AM.

Details

Reviewers

None

Group Reviewers

Konsole

Commits

Summary

Use custom dialog instead of KConfig's generic vague one.

BUG: 378784

Repository

R319 Konsole

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cfeck added inline comments.

src/ProfileManager.cpp
333	Use positional arguments instead of string concatenation. See e.g. https://commits.kde.org/knewstuff/6bbad707c5294ccb9c08c43c57c481728f48ca9f

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/ProfileManager.cpp (7 lines)
M			src/ProfileWriter.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13622	3148c0d		Apr 20 2017, 2:04 AM	★	★
Diff 2	13683	3148c0d	- Use positional arguments instead of string concatenation.	Apr 22 2017, 12:39 AM	★	★
Diff 3	13878	2b56917	R319:aaee4c713c784f481e4918e54b8429e2e531d9f6	Apr 27 2017, 2:26 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
321b9a1a38f4	82b99abfe9d9	9177779d8e0b	Kurt Hindenburg	Use positional arguments instead of string concatenation.	Apr 22 2017, 12:39 AM
9177779d8e0b	29c33272e9e5	3148c0d9e814	Kurt Hindenburg	Check to verify we have write permissions when saving profiles (Show More…)	Apr 20 2017, 2:03 AM