Besides de-duplication being a nice thing this also solves
translations getting installed into an undesired location. It
happens because at the time "ki18n_install(po)" (added on tarball
generation in order to install translations) is processed,
KDEInstallDirs is not yet included and LOCALE_INSTALL_DIR is not
defined, which leads to ki18n_install setting it to a default value.
Details
Details
- Reviewers
ltoscano - Group Reviewers
KDE Applications - Commits
- R451:70df0d526188: Move common parts to the top-level CMakeLists.txt
Diff Detail
Diff Detail
- Repository
- R451 KDE Development Utils
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Yes, thanks. I simply mirrored the old behavior when proting, but this makes more sense.