Keep startup notifications launcher-sized when inserting at launcher position.

Authored by hein on Apr 19 2017, 11:06 AM.



When "Keep launchers seperate" is disabled, startup notifications
replace launchers at their original position. This changes the
layout for this mode to keep the startup notification item the size
of the launcher item it replaces (the visual result being a throbber
on the launcher instead of the launcher being replaced by a "task"
with a throbber - iow, the expansion to task size is delayed until
a window appears).

This helps the minimize the jarring visual fallout in cases where
we can match the startup notification to the launcher, but not the
window to the startup notification (due to broken/missing window
metadata), as no longer will two task-sized items co-exist - instead
the throbber comes and goes on the launcher, seperate from the task
item for the unidentified window. It also minimizes visual fallout
if app startup fails or the app merely creates an SNI instead of a

This change was suggested by Netrunner Linux, which ships a Task
Manager with "Keep launchers seperate" disabled by default.

Depends on D5504.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Apr 19 2017, 11:06 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2017, 11:06 AM
lukas requested changes to this revision.Apr 19 2017, 11:25 AM
lukas added a subscriber: lukas.

See the inline comment


/!\ Evil typo spotted

seperateLaunchers -> separateLaunchers

This revision now requires changes to proceed.Apr 19 2017, 11:25 AM
hein added a comment.Apr 19 2017, 2:14 PM

Will fix lukas' error tomorrow, please review past it in the meantime in case there's more :)

hein updated this revision to Diff 13625.Apr 20 2017, 9:27 AM
hein edited edge metadata.

Fix typo.

broulik accepted this revision.Apr 20 2017, 9:36 AM
broulik added a subscriber: broulik.
broulik added inline comments.


hein updated this revision to Diff 13626.Apr 20 2017, 9:40 AM

Add readonly.

broulik accepted this revision.Apr 20 2017, 9:41 AM
This revision was automatically updated to reflect the committed changes.