Differential D5470

Make build against Qt 5.9.0
ClosedPublic
Actions

Authored by rjvbb on Apr 15 2017, 9:15 PM.

Details

Reviewers
yuyichao
davidedmundson
Summary

This patch makes QtCurve build against Qt 5.9.0 (RC) by replacing the MOArrow() argument QFlags<State> state with State state. The former is *presumably* a redundant and (now) incorrect equivalent of the latter as I have not been able to observe any runtime differences with the original code built against Qt 5.8.0 .

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
rjvbb created this revision.Apr 15 2017, 9:15 PM
yuyichao accepted this revision.Apr 15 2017, 10:49 PM
This revision is now accepted and ready to land.Apr 15 2017, 10:49 PM
davidedmundson accepted this revision.Apr 16 2017, 1:31 PM
davidedmundson added a subscriber: davidedmundson.

From what I can see the former was simply always wrong. It was previously QFlags<QFlags<StateFlag>>

It just happens that it had no side effects; as an enum mostly behaves like an int, and QFlags<> mostly behaves like an int, so it didn't really matter.

rjvbb closed this revision.Apr 17 2017, 9:13 AM

That's what I thought too, QFlags allows to make the compiler more pedantic but (usually) doesn't change runtime behaviour of compiled code.

https://commits.kde.org/qtcurve/7ddd3782ea5635cc0d6a6d292824da85ae9d1bb8

Revision Contents
Changeset List

PathPackages
Mqt5/style/qtcurve.h (4 lines)

Diff 13498

View Options

qt5/style/qtcurve.h

Loading...