Nextcloud Upload Purpose Plugin
ClosedPublic

Authored by yuenlim on Apr 15 2017, 3:08 PM.

Details

Summary

A basic-ish nextcloud purpose plugin for use with quickshare. Uses the owncloud kaccount provider (had a hoot of a time figuring that out!).

For now simply uploads the item(s), without creating a share or anything. Uploads to root folder on the target nextcloud instance by default but user is able to specify a target folder by typing. Should handle all upload types including multiple urls and clipboard contents non-terribly, and avoids overwriting by suffixing a number to the filename if the same filename already exists on the target folder.

The intention is to start with something with minimal options and do something useful and sensible, and to top up better UX/features after.

Feedback welcome!

Diff Detail

Repository
R495 Purpose Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
yuenlim created this revision.Apr 15 2017, 3:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 15 2017, 3:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

neat :-) Looking forward to use it

Ping :) Think someone can help me review this?

davidedmundson added inline comments.
src/plugins/nextcloud/CMakeLists.txt
9

you need to set the translation domain (copy and paste the line from another CMakeLists)

src/plugins/nextcloud/nextcloudjob.cpp
83

Replace this first argument with KIO::suggestName(); you just need to know the name of the last one you tried; which you can extract from the URL you're using

Then you can kill: createTargetUrl

apol requested changes to this revision.Apr 19 2017, 11:13 AM

+1
Please look at David's comments and we'll integrate it.

This revision now requires changes to proceed.Apr 19 2017, 11:13 AM
yuenlim updated this revision to Diff 13596.Apr 19 2017, 12:52 PM
yuenlim edited edge metadata.

Addressed comments!

yuenlim marked 2 inline comments as done.Apr 19 2017, 12:54 PM

Hope the translation domain part is correct. I only found it in the phabricator plugin's CMakeLists, most of the other plugins don't seem to have it.

yuenlim updated this revision to Diff 13598.Apr 19 2017, 12:57 PM

Oops minor mistake. Forgot to remove the declaration of createTargetUrl

apol accepted this revision.Apr 19 2017, 2:31 PM

Okay, let's integrate it and then we see how it works.

Can you maybe blog about it so the world knows?

This revision is now accepted and ready to land.Apr 19 2017, 2:31 PM

Sure! I was planning to.

Closed by commit R495:ef8548fadc39: Nextcloud upload purpose plugin (authored by Lim Yuen Hoe <yuenhoe@hotmail.com>). · Explain WhyApr 19 2017, 9:04 PM
This revision was automatically updated to reflect the committed changes.