update baloo kcm docbook
ClosedPublic

Authored by lueck on Apr 14 2017, 7:55 AM.

Details

Summary

bump date+releaseinfo
fix wrong gui term
add option about file content indexing

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Apr 14 2017, 7:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 14 2017, 7:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Apr 14 2017, 9:12 AM
This revision is now accepted and ready to land.Apr 14 2017, 9:12 AM
fvogt requested changes to this revision.Apr 14 2017, 9:21 AM
fvogt added inline comments.
doc/kcontrol/baloo/index.docbook
62

That is a bit misleading IMO, "Use 'Also index file content' to only index the filename or [...]"

This revision now requires changes to proceed.Apr 14 2017, 9:21 AM
ltoscano added inline comments.
doc/kcontrol/baloo/index.docbook
62

Uh, how is it different from the current text?

fvogt added inline comments.Apr 14 2017, 12:18 PM
doc/kcontrol/baloo/index.docbook
62

Which current text? This got added.

I'd phrase it like "Use 'Also index file content' to also index the file contents additional to the file names".

ltoscano added inline comments.Apr 14 2017, 12:21 PM
doc/kcontrol/baloo/index.docbook
62

Right, I wanted to say "proposed text", not "current text", and I misread your comment, I thought that the sentence was a proposal and not the quote of the proposal to show that it's misleading. Thanks for the alternative (maybe as "index the file contents in addition to the file names"?)

lueck updated this revision to Diff 13464.Apr 15 2017, 12:51 PM
lueck edited edge metadata.

use phrase suggested by Fabian Vogt

fvogt accepted this revision.Apr 15 2017, 1:15 PM

Looks good to me, thanks!

This revision is now accepted and ready to land.Apr 15 2017, 1:15 PM
This revision was automatically updated to reflect the committed changes.