Currently the selected wallpaper is deselected when the "Apply"
button is clicked, as if no wallpaper is selected. This patch
fixes that. I didn't understand what the original restoreIndex
thing was trying to do by passing the count, so I gutted it and
wrote code that makes more sense to me.
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- Plasma/5.9
- Lint
No Linters Available - Unit
No Unit Test Coverage
wallpapers/image/imagepackage/contents/ui/config.qml | ||
---|---|---|
40 | Why even do anything? You're selecting the currently selected item again. Which does nothing. You can surely just delete this (and restoreIndex and the Connection) |
Comment Actions
I wasn't sure (and admittedly didn't check) whether the source model does a reset causing the index to revert to 0. I kinda assumed that's why whoever wrote this added restore. If that's not the case yeah I'll just nix it.
This code could use a lot of cleanup, much of it seems written hurriedly.