Differential D5433

Refactor kreportconfigurationfilterdlg.cpp
ClosedPublic
Actions

Authored by wojnilowicz on Apr 13 2017, 6:51 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:4dc8d5b62541: Refactor kreportconfigurationfilterdlg.cpp

Summary

kreportconfigurationfilterdlg has now meaningful, shorter names which should facilitate development.
Moreover ui object is used where applicable to reference ui objects, which is shorter than findChild and less prone to errors.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz created this revision.Apr 13 2017, 6:51 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 14 2017, 9:10 AM

Closed by commit R261:4dc8d5b62541: Refactor kreportconfigurationfilterdlg.cpp (authored by wojnilowicz). · Explain WhyApr 15 2017, 1:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kmymoney/dialogs/kreportconfigurationfilterdlg.h (23 lines)
M		kmymoney/dialogs/kreportconfigurationfilterdlg.cpp (235 lines)
M		kmymoney/views/kreportsview.h (6 lines)
M		kmymoney/views/kreportsview.cpp (50 lines)
M		kmymoney/widgets/CMakeLists.txt (14 lines)
D	M	kmymoney/widgets/kmymoneyreportconfigtab1decl.ui (149 lines)
V		kmymoney/widgets/{kmymoneyreportconfigtab2decl.ui → reporttabrowcolpivot.ui}
V		kmymoney/widgets/{kmymoneyreportconfigtab3decl.ui → reporttabrowcolquery.ui}
V		kmymoney/widgets/{kmymoneyreportconfigtabchartdecl.ui → reporttabchart.ui}
V		kmymoney/widgets/{kmymoneyreportconfigtabimpl.h → reporttabimpl.h}
V		kmymoney/widgets/{kmymoneyreportconfigtabimpl.cpp → reporttabimpl.cpp}
V		kmymoney/widgets/{kmymoneyreportconfigtabrangedecl.ui → reporttabrange.ui}
D	M	kmymoney/widgets/kmymoneyreportcontroldecl.ui (141 lines)
V		kmymoney/widgets/{kmymoneyreportcontrolimpl.h → reportcontrolimpl.h}
V		kmymoney/widgets/{kmymoneyreportcontrolimpl.cpp → reportcontrolimpl.cpp}
A	M	kmymoney/widgets/reportcontrol.ui (149 lines)
V		kmymoney/widgets/{reportcontrolimpl.h ← kmymoneyreportcontrolimpl.h} (22 lines)
V		kmymoney/widgets/{reportcontrolimpl.cpp ← kmymoneyreportcontrolimpl.cpp} (11 lines)
V		kmymoney/widgets/{reporttabchart.ui ← kmymoneyreportconfigtabchartdecl.ui} (4 lines)
A	M	kmymoney/widgets/reporttabgeneral.ui (148 lines)
V		kmymoney/widgets/{reporttabimpl.h ← kmymoneyreportconfigtabimpl.h} (59 lines)
V		kmymoney/widgets/{reporttabimpl.cpp ← kmymoneyreportconfigtabimpl.cpp} (62 lines)
V		kmymoney/widgets/{reporttabrange.ui ← kmymoneyreportconfigtabrangedecl.ui} (6 lines)
V		kmymoney/widgets/{reporttabrowcolpivot.ui ← kmymoneyreportconfigtab2decl.ui} (41 lines)
V		kmymoney/widgets/{reporttabrowcolquery.ui ← kmymoneyreportconfigtab3decl.ui} (4 lines)