| cullmann |
| Framework: Syntax Highlighting | |
| KTextEditor | |
| Kate |
It is a modified version of SCSS syntax. Major difference is variable start with @ instead of $. It performs better with LESS' nested rules and major language features.
Customize function and some advanced usage may not look so good. But they are rarely used. The fall back style is still readable.
| Lint Skipped |
| Unit Tests Skipped |
Hi, given I have no real idea about this HL, looks not wrong, but could you add/extend a unit test?
Then this can go in I would say.
Thanks for the change!
Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...
That patch is based on my SCSS syntax. Since that has been committed, it will be a hard work to compare and update rules.
I do not know how to make unit test. Is here any documentation.
And nowadays I became really busy on work and KDE translation stuff. So I will not have time to check this again. Sorry...
In that case, can you judge whether your patch or the other one is better?
Add for review: @gszymaszek @jtamate
They didn't include any screenshots in https://phabricator.kde.org/D5799 so I make my own:
The results are almost the same except text styles. Left is theirs, right is mine. In my version, I use colored fonts for property name, instead of bold fonts. Also, I use italic text for :nth-child(), :hover.
So I think either of them are good choice. Mine patch doesn't add new things to their version. So no need to merge this again.
Ok, thanks for comparing it.
Sorry that I didn't look at it earlier, my fault :/
You can abandon this change then.