Polish ItemViewHeader, solve binding loops
ClosedPublic

Authored by apol on Apr 12 2017, 4:31 PM.

Details

Summary

Don't assume "page" in the namespace of ItemViewHeader, use view instead
which we have and symbolizes the same.
Don't change the implicitHeight when contentY is < 0.

Smooth ItemViewHeader

Make page property readonly. Nobody is accessing it and it's private
anyway.
When there's an image, don't wait to have the image to resize the header,
it makes the whole UI change without much sense as it should be fast.
Properly access the page property by name of the object, rather than having
QML go through the object tree. It failed to find the property sometimes.

Test Plan

Tests still pass, I don't get tons of warnings on Discover

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 12 2017, 4:31 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 12 2017, 4:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Apr 13 2017, 10:06 AM
This revision is now accepted and ready to land.Apr 13 2017, 10:06 AM
This revision was automatically updated to reflect the committed changes.