Allow to edit system color schemes
AbandonedPublic

Authored by mart on Apr 11 2017, 3:01 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Allow to edit and save system-wide color schemes.
it saves them in the user home and they will override the global one
the remove button becomes a "default values" button, that will remove
the local file and restore the system global one.

Test Plan

modified a global color scheme, saved, applied it, resetted it,
applied it

Diff Detail

Repository
R119 Plasma Desktop
Branch
phab/colorschemeEdit
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Apr 11 2017, 3:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 11 2017, 3:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added inline comments.
kcms/colors/colorscm.cpp
219

and you need to set it to disabled

otherwise if you edit a theme then reset it, you'll now have an option to remove a system theme.

This patch breaks the "Defaults" button as it will reset the index, but you'll still have your custom changes.

I don't see how this patch solves anything, previously you could edit a global scheme and the workflow was just as easy; you click Edit, the only difference is you had to give it a new name.

kcms/colors/colorscm.cpp
164

This patch doesn't actually address the actual issue that I know you were trying to fix - this line.

mart abandoned this revision.Jun 30 2017, 2:27 PM