Add appdata file for Naval Battle in kf5 based master
ClosedPublic

Authored by lueck on Apr 10 2017, 7:17 PM.

Details

Summary

info from games.kde.org

Test Plan

appstreamcli validate org.kde.knavalbattle.appdata.xml -> no errors/warnings
build + install

Diff Detail

Repository
R405 Naval Battle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Apr 10 2017, 7:17 PM
lueck added a comment.Apr 14 2017, 8:31 AM

Please review, thanks

Maybe we can omit "by KDE" here (the group already says it). Please update the review for the master branch including the renaming of the desktop file, otherwise it looks good to me.

lueck updated this revision to Diff 13477.Apr 15 2017, 5:13 PM

remove "by KDE"

Restricted Application edited edge metadata. · View Herald TranscriptApr 15 2017, 5:13 PM
ltoscano accepted this revision.Apr 15 2017, 5:15 PM

Thanks (and sorry for not checking, master is already KF5 for knavalbattle).

This revision is now accepted and ready to land.Apr 15 2017, 5:15 PM
lueck added a comment.Apr 15 2017, 5:15 PM

Please update the review for the master branch including the renaming of the desktop file, otherwise it looks good to me.

This is already for master branch and knavalbattle switch to kf5 some time ago
the desktop file already has the reverse naming scheme

This revision was automatically updated to reflect the committed changes.