Differential D5387

Add appdata file for KSirk in master branch + use reverse dns naming scheme for both deskop files
ClosedPublic
Actions

Authored by lueck on Apr 10 2017, 3:14 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

R413:b0c07d53396c: Add appdata file for KSirk in master branch + use reverse dns naming scheme for…

Summary

info from https://www.kde.org/applications/games/ksirk

Test Plan

appstreamcli validate org.kde.ksirk.appdata.xml -> no errors/warnings

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lueck created this revision.Apr 10 2017, 3:14 PM

I don't think that we need a separate appdata for ksirkeditor (probably not), but maybe it should be mentioned it in the <provides> tag.

Apart from this, it looks good to me. Please update it for the master branch (including the renaming of the desktop file).

renamed both desktop files
add ksirkskineditor to provides

Restricted Application edited edge metadata. · View Herald TranscriptApr 15 2017, 6:12 PM

Thanks

This revision is now accepted and ready to land.Apr 15 2017, 6:15 PM

Closed by commit R413:b0c07d53396c: Add appdata file for KSirk in master branch + use reverse dns naming scheme for… (authored by lueck). · Explain WhyApr 15 2017, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			ksirk/CMakeLists.txt (3 lines)
V			ksirk/{ksirk.desktop → org.kde.ksirk.desktop}
A	M		ksirk/org.kde.ksirk.appdata.xml (33 lines)
V			ksirk/{org.kde.ksirk.desktop ← ksirk.desktop}
M			ksirkskineditor/CMakeLists.txt (2 lines)
V			ksirkskineditor/{ksirkskineditor.desktop → org.kde.ksirkskineditor.desktop}
V			ksirkskineditor/{org.kde.ksirkskineditor.desktop ← ksirkskineditor.desktop}

Diff 13484

ksirk/CMakeLists.txt

Loading...

ksirk/ksirk.desktop

Loading...

ksirk/org.kde.ksirk.appdata.xml

Loading...

ksirk/org.kde.ksirk.desktop

Loading...

ksirkskineditor/CMakeLists.txt

Loading...

ksirkskineditor/ksirkskineditor.desktop

Loading...

ksirkskineditor/org.kde.ksirkskineditor.desktop

Loading...