Add appdata file for KGoldrunner in master branch + use reverse dns naming scheme for the deskop file
ClosedPublic

Authored by lueck on Apr 10 2017, 2:06 PM.

Details

Summary
Test Plan

appstreamcli validate src/org.kde.kgoldrunner.appdata.xml -> no errors/warnings

Diff Detail

Repository
R396 KGoldrunner
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Apr 10 2017, 2:06 PM

General comment for this and the other reviews: shouldn't we commit them to the current master for now? We are not sure about how many frameworks branches will be merged into master in time for 17.08.

src/org.kde.kgoldrunner.appdata.xml
5

isn't it usually CC0?

lueck added a comment.Apr 10 2017, 3:30 PM

General comment for this and the other reviews: shouldn't we commit them to the current master for now? We are not sure about how many frameworks branches will be merged into master in time for 17.08.

Sure, but then we should also use reverse dns naming scheme for the deskop files in master to avoid changing the <id> entry in *.appdata.xml files later.

src/org.kde.kgoldrunner.appdata.xml
5

please read https://phabricator.kde.org/D5052 "Show Older Changes"
quoting Matthias Klumpp:
"Ideally use FSFAP here, unless the project already uses CC0 somewhere, since CC0 requires you to include the license text with the sources, while FSFAP doesn't.
See https://spdx.org/licenses/FSFAP.html for the tiny license."

ltoscano accepted this revision.Apr 14 2017, 2:57 PM

Please apply this to the current master (renaming of the desktop file included, it's required by the desktop file spec anyway).

This revision is now accepted and ready to land.Apr 14 2017, 2:57 PM
ltoscano requested changes to this revision.Apr 14 2017, 3:05 PM

Better mark as "requiring changes"

This revision now requires changes to proceed.Apr 14 2017, 3:05 PM
lueck updated this revision to Diff 13479.Apr 15 2017, 5:37 PM
lueck edited edge metadata.
lueck retitled this revision from Add appdata file for KGoldrunner in frameworks branch to Add appdata file for KGoldrunner in master branch + use reverse dns naming scheme for the deskop file.
Restricted Application edited edge metadata. · View Herald TranscriptApr 15 2017, 5:37 PM
ltoscano accepted this revision.Apr 15 2017, 6:06 PM

Thanks

This revision is now accepted and ready to land.Apr 15 2017, 6:06 PM
This revision was automatically updated to reflect the committed changes.