Details
- Reviewers
ltoscano - Group Reviewers
KDE Games - Commits
- R396:32f121a12e19: Add appdata file for KGoldrunner in master branch + use reverse dns naming…
appstreamcli validate src/org.kde.kgoldrunner.appdata.xml -> no errors/warnings
Diff Detail
- Repository
- R396 KGoldrunner
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
General comment for this and the other reviews: shouldn't we commit them to the current master for now? We are not sure about how many frameworks branches will be merged into master in time for 17.08.
src/org.kde.kgoldrunner.appdata.xml | ||
---|---|---|
5 | isn't it usually CC0? |
Sure, but then we should also use reverse dns naming scheme for the deskop files in master to avoid changing the <id> entry in *.appdata.xml files later.
src/org.kde.kgoldrunner.appdata.xml | ||
---|---|---|
5 | please read https://phabricator.kde.org/D5052 "Show Older Changes" |
Please apply this to the current master (renaming of the desktop file included, it's required by the desktop file spec anyway).