Improve password dialogs
ClosedPublic

Authored by jgrulich on Apr 10 2017, 11:46 AM.

Details

Summary

Improve UI of all paswords dialogs. Previously we had two methods to setup UI
of the dialog, either for VPN or for regular connections like WiFi. I merged
them into one and both are now based on same UI, except that VPN connections
insert their specific widget into the dialog, while regular connections use
only one password field.

Screenshots of old password dialogs:

Screenshots of new password dialogs:

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Apr 10 2017, 11:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 10 2017, 11:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich edited the summary of this revision. (Show Details)Apr 10 2017, 11:51 AM

I like!

Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN* connection" (ie. capital). Also, add a colon at the end "password below:"

(Is there a way to get rid of the "KDE Daemon" caption and replace it by something more meaningful?)

I like!

Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN* connection" (ie. capital). Also, add a colon at the end "password below:"

Any suggestion what to use instead?

(Is there a way to get rid of the "KDE Daemon" caption and replace it by something more meaningful?)

None I would be aware of, even just removing the app name "KDE Daemon" would be sufficient, but given kded5 is the process where the dialog is instantiated then you get this .

jgrulich updated this revision to Diff 13317.Apr 11 2017, 6:21 AM

Highlight connection name with bold text and add colon at the end of sentence

mart added a subscriber: mart.Apr 11 2017, 11:41 AM

+1 from me as well

It looks like the spacing between the 4 content sections (title, description, passwords, buttons) is not always the same. To me it the spacing between title - description and password - buttons looks equal, but description - password seems to be smaller. I would suggest to increase the spacing between description - passwords, so that all 3 spacings are the same.

It looks like the spacing between the 4 content sections (title, description, passwords, buttons) is not always the same. To me it the spacing between title - description and password - buttons looks equal, but description - password seems to be smaller. I would suggest to increase the spacing between description - passwords, so that all 3 spacings are the same.

Possibly not possible to fix. Problem is that the icon on the left side determines the size of the first row. If I put only the title to the first row it will make a huge space between the title and the text. If I put both the title and the text to the first row it will somehow look normal, but still makes a different space between those two and the password field[s].

+1, other then the spacing mentioned above, I like the change.

mart accepted this revision.Apr 18 2017, 11:58 AM
This revision is now accepted and ready to land.Apr 18 2017, 11:58 AM
lukas added a subscriber: lukas.Apr 18 2017, 12:00 PM
This revision was automatically updated to reflect the committed changes.