Differential D5371

Set price precision on every security
ClosedPublic
Actions

Authored by wojnilowicz on Apr 9 2017, 7:10 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:3ae5debc64ef: Set price precision on every security

Summary

Lots of code has been changed. In general, this patch intends to replace global price precision with price precision per security. Thanks to this every security is displayed with proper price precision and not highest of all securities.

Things changed:

removed partsPerUnit - no usage anywhere
added pricePrecision - defaults to 4 but can be lowered as low as 2
added edit button to Tools->Currencies - allows setting pricePrecision for currencies
added pricePrecision to investment details dialog
removed "show national currencies" from investment view - it wasn't available without any investment, so it wasn't versatile
replaced tandem of precToDenom and convert to convertPrecision - it's more concise
smallestAccountFraction, smallestCashFraction and pricePrecision are checked for validity before loading from .kmy file
added yLabelsPrecison for graphs - user decides what precision he should get on y axis
removed some warnings from mymoneyreport and mymoneysecurity during compilation

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz edited the summary of this revision. (Show Details)Apr 10 2017, 5:12 PM

tbaumgart requested changes to this revision.Apr 10 2017, 6:18 PM

tbaumgart added a subscriber: tbaumgart.

tbaumgart added inline comments.

kmymoney/dialogs/kcurrencyeditordlg.cpp
49	Why don't you use MyMoneyMoney and it's formatMoney method here? Using double is what we try to avoid as much as possible.
kmymoney/mymoney/mymoneysecurity.h
62	Either use const int xxx = 4 or #define xxx 4 but not both, please.

This revision now requires changes to proceed.Apr 10 2017, 6:18 PM

wojnilowicz added inline comments.Apr 10 2017, 6:27 PM

kmymoney/mymoney/mymoneysecurity.h
62	Yes, but I use DEFAULT_CASH_FRACTION also for MyMoneySecurity() in mymoneysecurity.cpp. I want them to be consistent and defined by single DEFAULT_CASH_FRACTION. How can it be done otherway?

wojnilowicz updated this revision to Diff 13332.Apr 11 2017, 6:23 PM

wojnilowicz edited edge metadata.

wojnilowicz marked an inline comment as done.

Thomas,
I would like to commit this patch. Are you still against #define?

Łukasz

tbaumgart added inline comments.Apr 15 2017, 10:12 AM

kmymoney/mymoney/mymoneysecurity.h
62	I think you can do it as follows: in the .h file you declare a private member static const int DEFAULT_ACCOUNT_FRACTION; in the .cpp file you define this variable as follows (outside any method) static const int MyMoneySecurity::DEFAULT_ACCOUNT_FRACTION = 4; and in the ctor you write smallestAccountFraction = DEFAULT_ACCOUNT_FRACTION; In case you need the constant outside the scope of MyMoneySecurity, make the member variable public. You can then use MyMoneySecurity::DEFAULT_ACCOUNT_FRACTION in other contexts. Note: I am not 100% sure that this will work, but have seen and used similar constructions in other code. In case you can't achieve what you want go for the #define way.

wojnilowicz marked 3 inline comments as done.Apr 15 2017, 1:17 PM

wojnilowicz added inline comments.

kmymoney/mymoney/mymoneysecurity.h
62	I did it without #defines but a little bit simpler. Now it looks like eSECURITYTYPE.

wojnilowicz abandoned this revision.Apr 15 2017, 1:17 PM

wojnilowicz marked an inline comment as done.

Closed by commit R261:3ae5debc64ef: Set price precision on every security (authored by wojnilowicz). · Explain WhyApr 17 2017, 1:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kmymoney/converter/mymoneystatementreader.cpp (5 lines)
M		kmymoney/converter/tests/converter-test.cpp (2 lines)
M		kmymoney/dialogs/CMakeLists.txt (3 lines)
M		kmymoney/dialogs/investtransactioneditor.cpp (4 lines)
M		kmymoney/dialogs/kcurrencycalculator.cpp (18 lines)
M		kmymoney/dialogs/kcurrencyeditdlg.h (4 lines)
M		kmymoney/dialogs/kcurrencyeditdlg.cpp (23 lines)
M		kmymoney/dialogs/kcurrencyeditdlg.ui (49 lines)
A	M	kmymoney/dialogs/kcurrencyeditordlg.h (54 lines)
A	M	kmymoney/dialogs/kcurrencyeditordlg.cpp (55 lines)
A	M	kmymoney/dialogs/kcurrencyeditordlg.ui (156 lines)
M		kmymoney/dialogs/kequitypriceupdatedlg.cpp (11 lines)
M		kmymoney/dialogs/kmymoneypricedlg.cpp (4 lines)
M		kmymoney/dialogs/settings/ksettingsgeneraldecl.ui (67 lines)
M		kmymoney/kmymoney.cpp (4 lines)
M		kmymoney/kmymoney.kcfg (6 lines)
M		kmymoney/models/accountsmodel.cpp (2 lines)
M		kmymoney/mymoney/mymoneyfile.cpp (36 lines)
M		kmymoney/mymoney/mymoneysecurity.h (55 lines)
M		kmymoney/mymoney/mymoneysecurity.cpp (54 lines)
M		kmymoney/mymoney/storage/mymoneydbdef.cpp (3 lines)
M		kmymoney/mymoney/storage/mymoneystoragedump.cpp (1 line)
M		kmymoney/mymoney/storage/mymoneystoragesql.cpp (28 lines)
M		kmymoney/mymoney/tests/mymoneyforecast-test.cpp (2 lines)
M		kmymoney/mymoney/tests/mymoneysecurity-test.cpp (11 lines)
M		kmymoney/reports/kreportchartview.h (2 lines)
M		kmymoney/reports/kreportchartview.cpp (84 lines)
M		kmymoney/reports/listtable.cpp (5 lines)
M		kmymoney/reports/pivottable.h (1 line)
M		kmymoney/reports/pivottable.cpp (60 lines)
M		kmymoney/reports/querytable.cpp (16 lines)
M		kmymoney/reports/tests/pivotgrid-test.cpp (2 lines)
M		kmymoney/reports/tests/pivottable-test.cpp (2 lines)
M		kmymoney/reports/tests/querytable-test.cpp (2 lines)
M		kmymoney/views/kgloballedgerview.cpp (2 lines)
M		kmymoney/views/khomeview.cpp (2 lines)
M		kmymoney/views/kinvestmentview.cpp (6 lines)
M		kmymoney/views/kinvestmentviewdecl.ui (37 lines)
M		kmymoney/widgets/transaction.cpp (4 lines)
M		kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp (6 lines)
M		kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.cpp (3 lines)
M		kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpagedecl.ui (30 lines)
M		kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13271			Apr 9 2017, 7:08 PM	★	★
Diff 2	13332			Apr 11 2017, 6:22 PM	★	★
Diff 3	13536	2ef6763	R261:3ae5debc64ef54d3dc5b28315f7dd2263a157e0c	Apr 15 2017, 12:59 PM	★	★