Differential D5368

http slave: send error page after authorization failure
ClosedPublic
Actions

Authored by schwab on Apr 9 2017, 5:08 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:1740dae897ad: http slave: send error page after authorization failure
Test Plan

BUG: 373323.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
schwab created this revision.Apr 9 2017, 5:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 9 2017, 5:08 PM
ltoscano added a subscriber: ltoscano.Apr 9 2017, 5:13 PM

I can't comment on the patch, but please change the reference to the bug in the commit message from
Fixes bug 373323.

to
BUG: 373323

If the patch is committed, the bug will be closed, but only if it is referenced as BUG:

schwab edited the test plan for this revision. (Show Details)Apr 9 2017, 5:34 PM
dfaure added a subscriber: dfaure.Apr 15 2017, 8:24 AM

Seems consistent with the code further down, but I'm really puzzled because this code was the same in kdelibs4... Anyone with konqueror4 to test this? Otherwise I can do that in the office, 10 days from now.

schwab added a comment.Apr 15 2017, 8:58 AM

kio4 has the same problem.

dfaure accepted this revision.Apr 15 2017, 6:10 PM

OK then ;)

This revision is now accepted and ready to land.Apr 15 2017, 6:10 PM
Closed by commit R241:1740dae897ad: http slave: send error page after authorization failure (authored by schwab, committed by aacid). · Explain WhyApr 17 2017, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ioslaves/http/http.cpp (4 lines)

Diff 13526

View Options

src/ioslaves/http/http.cpp

Loading...