Fix query for available modules
ClosedPublic

Authored by aacid on Apr 8 2017, 5:12 PM.

Details

Summary

The old query was bad because two reasons:

  • it didn't use the same query systemsettings uses fo
  • it didn't use exist so if the first property did not exist the second one was not evaluated since the parser bailed out
Test Plan

Ran kcmshell5 --list, it's better now

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Apr 8 2017, 5:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2017, 5:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Apr 9 2017, 10:11 PM
apol added a subscriber: apol.
apol added inline comments.
kcmshell/main.cpp
62

Use QStringLiteral()?

This revision is now accepted and ready to land.Apr 9 2017, 10:11 PM
This revision was automatically updated to reflect the committed changes.