Differential D5343

applet: Reset height of item label
ClosedPublic
Actions

Authored by drosca on Apr 8 2017, 7:58 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R115:d046b6b288b1: applet: Reset height of item label
R994:d046b6b288b1: applet: Reset height of item label
Summary

Fixes item label text jumping up and down when resizing applet or the
text changes.

Test Plan

Issue fixed

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Apr 8 2017, 7:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2017, 7:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni added a subscriber: anthonyfieroni.Apr 8 2017, 2:17 PM
anthonyfieroni added inline comments.
applet/contents/ui/ListItemBase.qml
105

maximumLineCount: 1 should be added or elide will stop to work
http://doc.qt.io/qt-5/qml-qtquick-text.html#elide-prop

drosca added inline comments.Apr 8 2017, 2:22 PM
applet/contents/ui/ListItemBase.qml
105

Eliding still works though.

davidedmundson accepted this revision.May 2 2017, 11:16 AM
This revision is now accepted and ready to land.May 2 2017, 11:16 AM
Closed by commit R115:d046b6b288b1: applet: Reset height of item label (authored by drosca). · Explain WhyMay 2 2017, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14073

View Options

applet/contents/ui/ListItemBase.qml

Loading...