Differential D5333

[Plasma Windowed] Disable standard actions on SNI
ClosedPublic
Actions

Authored by broulik on Apr 7 2017, 2:51 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:71dda89bb80d: [Plasma Windowed] Disable standard actions on SNI
Summary

We add our own "Close" item manually. Also, add a separator (QMenu is smart enough not to show separators at the beginning of the list, ie. if there's no applet actions)

Test Plan

No Quit entry anymore

Verified that plasmawindowed still quits when closing the last applet window

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 7 2017, 2:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2017, 2:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Apr 10 2017, 8:45 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
plasma-windowed/plasmawindowedview.cpp
115

or we could just not manually add our own close entry? Would be less code and give us the minimzeRestore thing too?

This revision is now accepted and ready to land.Apr 10 2017, 8:45 PM
broulik added inline comments.Apr 10 2017, 8:51 PM
plasma-windowed/plasmawindowedview.cpp
115

SNI's default action would *quit* the app but one plasma-windowed instance can host multiple applet windows, each of which can show an SNI.

Closed by commit R120:71dda89bb80d: [Plasma Windowed] Disable standard actions on SNI (authored by broulik). · Explain WhyApr 18 2017, 8:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13198

View Options

plasma-windowed/plasmawindowedview.cpp

Loading...