Differential D5331

Whitelist Switch keyboard layout to shortcuts shortcuts
ClosedPublic
Actions

Authored by broulik on Apr 7 2017, 10:45 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R133:4180796cd389: Whitelist Switch keyboard layout to shortcuts
Summary

This changes the whitelist to be a QRegularExpression to allow for more sophisticated whitelisting.
A expression matching "Switch keyboard layout to .*" has been added.

BUG: 378531
FIXED-IN: 5.12.0

Test Plan

Verified that

  • Volume keys still work
  • Switch to next keyboard layout still works
  • Switch keyboard layout to German and Neo I configured now work
  • Pressing another custom shortcut doesn't do anything

Diff Detail

Repository
R133 KScreenLocker
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 7 2017, 10:45 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2017, 10:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Apr 7 2017, 11:56 AM

Might be better to just whitelist startsWith("Switch to keyboard layout...") stuff?

graesslin edited edge metadata.Apr 7 2017, 12:48 PM
In D5331#100342, @broulik wrote:

Might be better to just whitelist startsWith("Switch to keyboard layout...") stuff?

yes or to actually read out the registered shortcuts. I'm uneasy with just whitelisting all shortcuts for the component as in the Wayland case it's KWin owning that component.

broulik updated this revision to Diff 24222.Dec 21 2017, 1:31 PM
broulik retitled this revision from Whitelist all Keyboard Layout Switcher shortcuts to Whitelist Switch keyboard layout to shortcuts shortcuts.
broulik edited the summary of this revision. (Show Details)
graesslin accepted this revision.Dec 21 2017, 3:25 PM
This revision is now accepted and ready to land.Dec 21 2017, 3:25 PM
Closed by commit R133:4180796cd389: Whitelist Switch keyboard layout to shortcuts (authored by broulik). · Explain WhyDec 21 2017, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mglobalaccel.cpp (32 lines)

Diff 24222

View Options

globalaccel.cpp

Loading...