Differential D5326

RFC: Update to Astyle 1.24 (latest 1.x release)
ClosedPublic
Actions

Authored by kfunk on Apr 6 2017, 11:49 PM.

Details

Reviewers

mwolff

Group Reviewers

KDevelop

Commits

R51:d609028bea6c: Update to Astyle 1.24 (latest 1.x release)

Summary

Problems:
There was some debugging mechanism hacked into the astyle lib sources,
which added 'ASIgnore' & 'AS/Ignore' markers. Without this support,
generated sources contain these markers unconditionally and thus fail
the compilation:

projectmanagers/qmake/parser/qmakeast.h:13:1: error: expected
unqualified-id
<U+0001>!ASIgnore"!!
^

With the update to Astyle 1.24, this debugging mechanism got disabled.
(I don't really know what it's for...)

Test Plan

Compiled kdevelop (the QMake plugin uses kdev-pg-qt)

Diff Detail

Repository

R51 KDevelop: PG Qt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk created this revision.Apr 6 2017, 11:49 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 6 2017, 11:49 PM

Now if we could summon one of the kdevelop-pg-qt oldies...

kfunk edited the test plan for this revision. (Show Details)Apr 10 2017, 11:58 AM

Does kdev-php and the other plugins that leverage this still work afterwards? If so, +1. That's really the only test that I'd be doing myself :) No idea about what this ASIgnore stuff is supposed to be...

This revision is now accepted and ready to land.May 14 2017, 10:37 AM

Closed by commit R51:d609028bea6c: Update to Astyle 1.24 (latest 1.x release) (authored by kfunk). · Explain WhyJun 5 2017, 1:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kdev-pg/ASBeautifier.cpp (1716 lines)
M		kdev-pg/ASEnhancer.cpp (541 lines)
M		kdev-pg/ASFormatter.cpp (4085 lines)
A	M	kdev-pg/ASLocalizer.h (159 lines)
A	M	kdev-pg/ASLocalizer.cpp (1098 lines)
M		kdev-pg/ASResource.cpp (478 lines)
M		kdev-pg/astyle.h (659 lines)
M		kdev-pg/kdev-pg-beautifier.h (11 lines)
M		kdev-pg/kdev-pg-beautifier.cpp (29 lines)
M		kdev-pg/kdev-pg-lexer.cc (547 lines)
M		kdev-pg/kdev-pg-lexer.ll (3 lines)