[KWin Scripts KCM] Restore "import" option
ClosedPublic

Authored by broulik on Apr 6 2017, 9:49 AM.

Details

Summary

Port it to KPackage installJob and improve usability slightly.

Test Plan

Installed a .kwinscript package I downloaded, it showed up in the list right away and after hitting "Apply" it was loaded fine and worked.


Installing a broken package shows an error widget with explanation:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 6 2017, 9:49 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 6 2017, 9:49 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested changes to this revision.Apr 6 2017, 3:04 PM
graesslin added a subscriber: graesslin.

Looks good overall

kcmkwin/kwinscripts/module.cpp
116

the lambda is rather long. Maybe a proper method would be more suited in this case?

119

please use i18nc and explain the %1

130

same here: i18nc

This revision now requires changes to proceed.Apr 6 2017, 3:04 PM
broulik updated this revision to Diff 13822.Apr 26 2017, 12:13 PM
broulik edited edge metadata.
  • Address issues
graesslin accepted this revision.Apr 26 2017, 2:51 PM
This revision is now accepted and ready to land.Apr 26 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.