Fixed WHERE conditions handling
ClosedPublic

Authored by staniek on Apr 3 2017, 11:41 PM.

Details

Summary
  • Fixed possible issue: the WHERE condition can be lost while converting query to SQL This can be seen in Kexi Query Designer.
  • Query: validate and offer error message/description while setting or extending WHERE conditions This helps to find table/column names for WHERE expressions in Kexi Query Designer.

+ improve docs

  • Query parsing: try harder to locate positions of table/table aliases This fixes stability of Kexi Query Designer

See https://bugs.kde.org/377579

Test Plan

Run all KDb tests, try Kexi improvements within D5295

Note: for 3.0 branches! Will be merged to master when accepted.

Diff Detail

Repository
R15 KDb
Branch
3.0
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek created this revision.Apr 3 2017, 11:41 PM
Restricted Application added a project: KDb. · View Herald TranscriptApr 3 2017, 11:41 PM
staniek edited the test plan for this revision. (Show Details)Apr 3 2017, 11:46 PM
This revision was automatically updated to reflect the committed changes.

@piggz Committed but I'd like to ask for auditing this

staniek reopened this revision.Apr 5 2017, 10:51 PM
This revision was automatically updated to reflect the committed changes.