If resources are not found in filesystem, they will be read from binary via resource path
Details
Details
- Reviewers
mwolff kfunk - Group Reviewers
KDevelop - Commits
- R32:3c3d01fe78a4: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc
Compile, remove file from 'regular' system locations, ensure related feature still functions
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| app/splash.cpp | ||
|---|---|---|
| 41 | Why the check? We can assert that splash.qml is in the QRC. | |
| app/splash.cpp | ||
|---|---|---|
| 41 | The QStandardPaths::locate() call above doesn't search the QRC. I was taking a strategy of 'smallest change' .. Which, in this case means that if the file is in the "legacy" path location, it would load that instead of the QRC, which.. For other files is sometimes desired (Then they can be modified, etc) That said, you raise a good point. There's no reason to allow a custom splash.qml. This entire block could be replaced with: setSource(QUrl("qrc:/kdevelop/splash.qml"));I will do that. | |
Comment Actions
some small changes, then go for it
| app/splash.cpp | ||
|---|---|---|
| 41 | make this QUrl(QStringLiteral(...)) | |
| projectmanagers/cmake/tests/manual/kde4app/CMakeLists.txt | ||
| 18 ↗ | (On Diff #1239) | drop this, it's a test, not really getting build |
| projectmanagers/cmake/tests/manual/kde4app/kde4app.qrc | ||
| 1 ↗ | (On Diff #1239) | drop this, it's a test, not really getting build |
Comment Actions
After fixing Milian's concerns: LGTM
Great work!
| app/CMakeLists.txt | ||
|---|---|---|
| 20 | Nitpick: Here and in other parts: No spaces inside after/before '('/')' | |