Fix TasksModel.anyTaskDemandsAttention not updating on window closure.
ClosedPublic

Authored by hein on Mar 31 2017, 10:21 AM.

Details

Summary

Previously we updated the prop after checking for
AbstractTasksModel::IsDemandingAttention on window closure, but
as the window is gone, we can't actually get state for it anymore,
so we always need to update.

To make up for it, this patch also optimizes the prop updates to occur
only once per insert/remove batch - this is a bit academic because
the source models currently only insert single rows at a time, but
it's good hygiene.

BUG:378254

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Mar 31 2017, 10:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2017, 10:21 AM
mart accepted this revision.Mar 31 2017, 10:32 AM

tested, works

This revision is now accepted and ready to land.Mar 31 2017, 10:32 AM
This revision was automatically updated to reflect the committed changes.