Details
- Reviewers
ltoscano - Commits
- R491:06b2942a79bb: Remove more references to KDE as a DE
Diff Detail
- Repository
- R491 KGraphViewer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I propose to also remove the "by KDE" in the summary comments, as that does not help to understand the purpose of the program.
Most apps I saw do not have such a comment in such summary comments about the origin of a software.
Rather might still be misinterpreted to be KDE-centric.
| doc/en_US/index.docbook | ||
|---|---|---|
| 64 | maybe the sentence about "The programs that comes... " could be made more generic and talk about the past "It started as a more modern alternative to the limited and often off-looking programs shipped with &graphviz;" I'm not sure about the removal of "by KDE" here. But given that we don't pay the bytes, we could extend as "built by KDE community", "built using technologies developed by the KDE community" or other variations. | |
| 86 | Or at least the thing of "by KDE" as explained above could go here. | |
| 135 | I think I bumped the minimum version | |
| src/main.cpp | ||
| 47 ↗ | (On Diff #12995) | here as you prefer. just to note that other programs have "by KDE" here. |
| src/org.kde.kgrapheditor.desktop | ||
| 47 ↗ | (On Diff #12995) | ditto as above |
Thanks for feedback. Will push the non-index.docbook changes already, as I changed those strings today already and quick translators should not need to update them 2x.
| doc/en_US/index.docbook | ||
|---|---|---|
| 64 | I tried to stay away from rewording other outdated content, as otherwise larger parts will have to be updated :) | |
| 86 | Okay, will give that some try. | |
| 135 | Minimum version is only given for KDE Frameworks, but not Qt (though will thus be implicit from whatever the min KF needs). I only changed 4->5 and kept the ".x" though as chance is low that this manual will be kept in sync with the CMakeLists.txt, and not being explicit at least does not say something wrong. | |
| src/main.cpp | ||
| 47 ↗ | (On Diff #12995) | Not too many though, at least the few I checked (KWrite, Dolphin, KDevelop, Konsole) do not. (Okteta also not, but that was already me ;) ). |
Leave all "by KDE" or rewrite it as "by the KDE community" if adequate. Remove the "for KDE" or rewrite it to "by...".
KDE is the community. "By KDE" is totally fine. For example take a look at the new splash screen after login in Plasma, which does it the same way.
| doc/en_US/index.docbook | ||
|---|---|---|
| 86 | No, I rather put this into the abstract, it felt too random here. | |
Yes, this is what this patch is about, "for KDE" -> "by KDE" :)
Just, there are some places where making a fuse about the origin of a software IMHO is not really needed, or rather distracting, like in the short summaries, so that's why "for KDE" -> "" is done in such places.
Ok, great! :) I'm not sure if the official version is just "by KDE" or "by the KDE community". I think on the splashscreen is the short one.
Ups, sorry, I have a problem with email notifications from Phabricator (or better, the service used for the delivery, which is external) since more or less this review was posted, and I didn't see the updates. Thanks for the changes.