fixes for plasmawindowed sni support
ClosedPublic

Authored by mart on Mar 29 2017, 2:17 PM.

Details

Summary
  • support one sni per applet
  • fix commandline parsing when the process is already running (--statusnotifier paramenter was breaking parsing)
  • sync applet and sni status
  • toggle shown/hidden based on current window status
  • close action closes the plasmoid, not the whole app
  • applet contextual action in context menu
Test Plan

tested with different applets, more than once,
context menus correctly synced, status correctly synced
can quit plasmoids one by one

Diff Detail

Repository
R120 Plasma Workspace
Branch
phab/pwsni
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 29 2017, 2:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 29 2017, 2:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested changes to this revision.Mar 29 2017, 6:18 PM
apol added a subscriber: apol.
apol added inline comments.
plasma-windowed/plasmawindowedcorona.cpp
64

!

plasma-windowed/plasmawindowedview.cpp
215

m_statusNotifier should be a QPointer?

This revision now requires changes to proceed.Mar 29 2017, 6:18 PM
mart updated this revision to Diff 12999.Mar 30 2017, 8:33 AM
mart edited edge metadata.

use QPointer

davidedmundson accepted this revision.Mar 30 2017, 11:29 AM
This revision was automatically updated to reflect the committed changes.
mart marked 2 inline comments as done.