Differential D5236

[Folder View] Port from deprecated ui() to uiDelegate()
ClosedPublic
Actions

Authored by broulik on Mar 29 2017, 11:43 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:7d49b8ed2c8f: [Folder View] Port from deprecated ui() to uiDelegate()
Summary

The former is deprecated and just returns uiDelegate() inside anyway.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 29 2017, 11:43 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 29 2017, 11:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 29 2017, 12:13 PM
This revision is now accepted and ready to land.Mar 29 2017, 12:13 PM
hein added a comment.Mar 29 2017, 12:14 PM

Make sure this really doesn't need a nullptr check though.

broulik added a comment.Mar 29 2017, 12:47 PM

From KIOCore Job:

// Exists for historical reasons only
KJobUiDelegate *Job::ui() const
{
    return uiDelegate();
}

so it shouldn't make any difference.

Closed by commit R119:7d49b8ed2c8f: [Folder View] Port from deprecated ui() to uiDelegate() (authored by broulik). · Explain WhyMar 29 2017, 12:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12961

View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...