[Folder View] Follow targetUrl() instead of url()
ClosedPublic

Authored by broulik on Mar 29 2017, 9:27 AM.

Details

Summary

This makes it consistent with Dolphin which, when cd'ing into a folder on desktop:/ actually opens /home/foo/Desktop/path (the target URL set by the KIO) and also fixes opening subfolders in my places:/ KIO which just links to the actual locations.

Test Plan

Both desktop popups and panel works, places:/ works fine now.
However, the title for files on the desktop is no longer "desktop > foo" but "Home > Desktop > foo" (which might even elide depending on language :/)

From KFileItem docs

Returns the target url of the file, which is the same as url() in cases where the slave doesn't specify UDS_TARGET_URL

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 29 2017, 9:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 29 2017, 9:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 29 2017, 9:46 AM

I'm not super happy with the label thing though ... does it at least still work correctly when Desktop is in Places?

This revision is now accepted and ready to land.Mar 29 2017, 9:46 AM

does it at least still work correctly when Desktop is in Places?

If you place a /home/foo/Desktop folder in places, it works fine, not with desktop:/ (which isn't user-accessible from Dolphin unless you enter the URL manually anyway)

This revision was automatically updated to reflect the committed changes.