Add override to methods that override methods on their parent class
AbandonedPublic

Authored by apol on Mar 28 2017, 10:47 PM.

Details

Reviewers
davidedmundson
graesslin
Group Reviewers
Plasma
Summary

I was trying to compile kwin and it was impossible to read the output because
clang complains if it should override and it doesn't
Something similar was done to Plasma as well.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 28 2017, 10:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 28 2017, 10:47 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript

In case you'd rather not want to introduce a git history wall:
-Wno-inconsistent-missing-override -Wno-inconsistent-missing-destructor-override -Wno-initializer-overrides

graesslin requested changes to this revision.Mar 29 2017, 10:58 AM

I would prefer if this IMHO useless warning gets disabled.

This revision now requires changes to proceed.Mar 29 2017, 10:58 AM
apol abandoned this revision.Mar 29 2017, 11:10 AM

I would prefer if this IMHO useless warning gets disabled.

override adds useful semantics to your code, that's never useless.

Oh well...

In D5232#98698, @apol wrote:

I would prefer if this IMHO useless warning gets disabled.

override adds useful semantics to your code, that's never useless.

Oh well...

A warning which breaks the warning output of legacy code (and that's what KWin is) is completely useless. Yes override is cool and useful. And KWin uses it in new code. But adjusting the old code - no that just makes the git history a mess. Nobody touches that code, nobody will change it.