Differential D5213

[Applet Alternatives] Fix icon size
ClosedPublic
Actions

Authored by broulik on Mar 28 2017, 9:22 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:e28ea7a47c96: [Applet Alternatives] Fix icon size
Summary

Another regression with new IconItem implicit size handling.
Unintuitively implicit size has precedence over regular size when placed in a Layout, since the latter is managed by it.

Test Plan

Plasma/5.8 branch pls
No longer get super huge icons in applet alternatives.
This patch makes sense either way.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 28 2017, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2017, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Mar 28 2017, 9:41 AM
This revision is now accepted and ready to land.Mar 28 2017, 9:41 AM
Closed by commit R119:e28ea7a47c96: [Applet Alternatives] Fix icon size (authored by broulik). · Explain WhyMar 28 2017, 9:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12904

View Options

desktoppackage/contents/explorer/AppletAlternatives.qml

Loading...