Port kde4_add_app_icon to ecm_add_app_icon
ClosedPublic
Actions

Authored by ltoscano on Mar 27 2017, 9:31 PM.

Details

Reviewers

abika

Group Reviewers

Krusader

Commits

Summary

Follow the same pattern of similar portings.

Test Plan

The code compiles on a GNU/Linux system. It was not tested on the
platforms where it should show visible effects (Windows and macOS).

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ltoscano added a project: Krusader.

Ping?

Same here: can compile but not test. I guess, its fine.

This revision is now accepted and ready to land.Mar 31 2017, 7:37 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (3 lines)
M			krusader/CMakeLists.txt (4 lines)
M			porting_todo.txt (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12884	9d0382c		Mar 27 2017, 9:31 PM	★	★
Diff 2	13029	2fc2524	R167:e08b0c9bb0f9e6e062e83d4e8a1a3e4d00502189	Mar 31 2017, 8:39 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4417ed46bd81	621384d6e20b	9d0382c1e4a2	Luigi Toscano	Port kde4_add_app_icon to ecm_add_app_icon (Show More…)	Mar 27 2017, 9:28 PM