This adds the widget style chooser evoked during the colour scheme chooser review (D5113).
Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
To be honest, I think all the dealing with default style, desktop style, bold font, etc is superfluous and in fact misleading:
The "default" style can actually depend not only on the OS, but on the distribution, etc.
Also the return of "cg.readEntry( "widgetStyle", fallback );" is actually the "current" style not the default. And should not be different from "QApplication()::style()".
In any case, none of this is really necessary here: IMHO the menu should just have the list of available styles (StyleFactory::keys()) and the "correct" radiobox selected at startup.
Wdyt ?
I don't disagree; it's how I would have implemented the widget when writing it from scratch for this application.
Simplified style selector widget that just shows the available styles and "ticks" the currently active style.
Implementation wise, perfect !
Some minor comments to be fixed, then ship it !
Thanks for the patch
kstyle/demo/oxygenstylechooser.cpp | ||
---|---|---|
37 | I "think" the policy is | |
47 | if the destructor does nothing (is the default), just remove it from the header and here. | |
kstyle/demo/oxygenstylechooser.h | ||
29 | Not sure there is an official policy here, but my preference goes for _not_ forward-declare classes on which I have no direct control. I would rather add the include explicitely. |