Differential D5172

Implement high DPI support in KWin QPA
ClosedPublic
Actions

Authored by davidedmundson on Mar 25 2017, 12:18 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:8ef184e1cd1b: Implement high DPI support in KWin QPA
Summary

Basically just a copy and paste from the relevant Qt Wayland parts.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2017, 12:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
markg added a subscriber: markg.Mar 25 2017, 4:00 PM
markg added inline comments.
plugins/qpa/screen.cpp
25

Looks like its unused.

78

c cast... no no no!
static_cast<qreal>(...)

graesslin accepted this revision.Mar 25 2017, 8:36 PM
graesslin added a subscriber: graesslin.

Apart from the two minor issues, looks good to me :)

plugins/qpa/screen.cpp
78

is the cast needed at all? It should be implicitly casted from int to real, shouldn't it?

This revision is now accepted and ready to land.Mar 25 2017, 8:36 PM
davidedmundson updated this revision to Diff 12807.Mar 25 2017, 11:10 PM

fixed spacing

graesslin added a comment.Mar 26 2017, 9:39 AM

the accepted still holds :-)

Closed by commit R108:8ef184e1cd1b: Implement high DPI support in KWin QPA (authored by davidedmundson). · Explain WhyApr 29 2017, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplugins/qpa/screen.h (1 line)
Mplugins/qpa/screen.cpp (7 lines)

Diff 13982

View Options

plugins/qpa/screen.h

Loading...
View Options

plugins/qpa/screen.cpp

Loading...