Context: Use DBus service watcher to reconnect to pulseaudio
ClosedPublic

Authored by drosca on Mar 25 2017, 10:25 AM.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Mar 25 2017, 10:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2017, 10:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Does PulseAudio have any DBus service? The applet could be DBus activated, too

Does PulseAudio have any DBus service? The applet could be DBus activated, too

Yes, but on its own connection, so I assume not supported to be DBus activated by plasma.

mart added a subscriber: mart.Mar 28 2017, 11:22 AM
In D5171#97466, @drosca wrote:

Does PulseAudio have any DBus service? The applet could be DBus activated, too

Yes, but on its own connection, so I assume not supported to be DBus activated by plasma.

connection or bus?
wouldn't be enough to just be dbus activated on the service org.pulseaudio.Server on the session bus?

In D5171#98353, @mart wrote:
In D5171#97466, @drosca wrote:

Does PulseAudio have any DBus service? The applet could be DBus activated, too

Yes, but on its own connection, so I assume not supported to be DBus activated by plasma.

connection or bus?
wouldn't be enough to just be dbus activated on the service org.pulseaudio.Server on the session bus?

Making the applet DBus activated on org.pulseaudio.Server should work, but the plasma-pa import can be (and is) used also in other places, so this change to Context is still needed.

drosca updated this revision to Diff 12909.Mar 28 2017, 11:51 AM

Use DBus service watcher

drosca retitled this revision from Context: Always try to reconnect when connection fails to Context: Use DBus service watcher to reconnect to pulseaudio.Mar 28 2017, 11:52 AM
drosca edited the summary of this revision. (Show Details)
drosca edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.May 2 2017, 11:16 AM
This revision is now accepted and ready to land.May 2 2017, 11:16 AM
This revision was automatically updated to reflect the committed changes.