Merge fully rewritten vector tool sinto Krita
ClosedPublic

Authored by dkazakov on Mar 23 2017, 12:27 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Maniphest Tasks
T1005: Overhaul the Vector system
Summary

This patch merges the work done for Kickstarter 2016 goal. At least most
of it. Please check the details of what was planned in the requirements
list here:

https://phabricator.kde.org/w/krita/vector_tool_requirements/

And here is an additional list of the work that is going to be postponed:

https://phabricator.kde.org/T1005#78222

Ref T1005

Test Plan

Basically, you need to check if the result conforms with what was declared
in the requirements in the list above.

Diff Detail

Repository
R37 Krita
Branch
kazakov/svg-loading
Lint
No Linters Available
Unit
No Unit Test Coverage
dkazakov created this revision.Mar 23 2017, 12:27 PM
dkazakov updated this object.
dkazakov added a project: Krita.

The patch is already in master

rempt accepted this revision.Jun 16 2017, 12:37 PM
rempt added inline comments.
libs/flake/KoBakedShapeRenderer.h
30

Needs dox -- also, the abbreviation Obb used in some parameters isn't clear to me.

libs/global/kis_signals_blocker.h
44

Hm, I know this was just a move of an existing utility class -- but why not pass a list or vector of QObjects?

This revision is now accepted and ready to land.Jun 16 2017, 12:37 PM
dkazakov closed this revision.Jul 6 2017, 1:33 PM

Patch was merged long ago