API: Make KReportDesignerSection constructed by KReportDesigner, hide the zoom handler, use more stack, some renames
ClosedPublic

Authored by staniek on Mar 20 2017, 11:56 PM.

Details

Summary

Improve APIs, hide some internals deeper

Also review Kexi https://phabricator.kde.org/D5121

Test Plan

Build, run tests and the example app

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek created this revision.Mar 20 2017, 11:56 PM
Restricted Application added a project: KReport. · View Herald TranscriptMar 20 2017, 11:56 PM
staniek updated this revision to Diff 12660.Mar 21 2017, 12:06 AM
  • GIT_SILENT Add missing parameter names, don't use set**(bool = ...) in APIs
staniek edited the summary of this revision. (Show Details)Mar 21 2017, 12:19 AM
piggz edited edge metadata.Mar 23 2017, 11:08 AM

How about adding _p to kreportzoomhandler files?

In D5120#97007, @piggz wrote:

How about adding _p to kreportzoomhandler files?

Oh, good idea.

staniek updated this revision to Diff 12725.Mar 23 2017, 11:36 AM
  • Hide more internals: KReportRuler, KReportZoomHandler, KReportZoomMode
staniek edited the summary of this revision. (Show Details)Mar 23 2017, 11:37 AM
In D5120#97007, @piggz wrote:

How about adding _p to kreportzoomhandler files?

Done, please look at the individual commit, mostly movements and renames.

piggz accepted this revision.Mar 23 2017, 11:52 AM
This revision is now accepted and ready to land.Mar 23 2017, 11:52 AM
This revision was automatically updated to reflect the committed changes.