Point CMake to Taglib includes matching the found Taglib library
ClosedPublic

Authored by mpyne on Mar 18 2017, 10:23 PM.

Details

Summary

We need to use target_include_directories so that CMake passes the right -I flags to find Taglib for the audio thumbnailer, the same way we use target_link_libraries to pass the right -L and -l flags.

On my system (with Taglib-git installed to my KF5 git root) kio-extras will find my git Taglib libraries but then try to build using the /usr/include Taglib headers. This would actually have worked OK except that my system Taglib headers are apparently old enough to be missing TagLib::MP4::File::hasMP4Tag

Test Plan

Builds and installs where it didn't before.

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mpyne created this revision.Mar 18 2017, 10:23 PM
elvisangelaccio accepted this revision.Mar 19 2017, 9:35 AM

The module should probably use pkg-config, but for now this will do.

This revision is now accepted and ready to land.Mar 19 2017, 9:35 AM
This revision was automatically updated to reflect the committed changes.