Differential D5083

fix compilation with old gcc
ClosedPublic
Actions

Authored by mart on Mar 17 2017, 1:22 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:2f22f0a935b6: fix compilation with old gcc
Summary

gcc 4.8.5 (opensuse leap) fails building modeltest with
CMakeFiles/testHistoryModel.dir/modeltest.cpp.o: In function `ModelTest::data()':
modeltest.cpp:(.text+0x5a57): undefined reference to `bool QTest::qCompare<int, unsigned int>(int const&, unsigned int const&, char const*, char const*, char const*, int)'

Test Plan

builds fine now
same thing should be done to modeltest usage in kwin

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 17 2017, 1:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2017, 1:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Mar 20 2017, 11:17 AM
davidedmundson added a subscriber: davidedmundson.

fix it then ship it.

klipper/autotests/modeltest.cpp
456

toUInt

This revision is now accepted and ready to land.Mar 20 2017, 11:17 AM
Closed by commit R120:2f22f0a935b6: fix compilation with old gcc (authored by mart). · Explain WhyMar 20 2017, 4:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mklipper/autotests/modeltest.cpp (2 lines)

Diff 12557

View Options

klipper/autotests/modeltest.cpp

Loading...