Add explicit cast to fix build with gcc-4.8
Details
Details
- Reviewers
apol - Commits
- R495:f35cc5e9ae91: Add explicit cast to fix build with gcc-4.8
Tested building for openSUSE Leap 42.2, which uses gcc 4.8
Diff Detail
Diff Detail
- Repository
- R495 Purpose Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/externalprocess/processjob.cpp | ||
|---|---|---|
| 50 | Wouldn't m_process.data() be more adequate? It's weird to explicitly cast into the container... Also it's an interesting change, I wasn't aware that QPointer didn't work in older gcc. :/ | |
| src/externalprocess/processjob.cpp | ||
|---|---|---|
| 50 | I think it's clearer to have an explicit cast to make a cast from a pointer-like object than calling m_process.data() which looks like it's getting some data from a QProcess object. If the argument doesn't convince you and you still want me to change that, tell me and I'll change it. | |