[Kompare] Rework on Files Page and save recently opened URLs
AbandonedPublic
Actions

Authored by jsalatas on Mar 17 2017, 8:05 AM.

Details

Reviewers

kkofler
heikobecker
kossebau

Summary

I tried to fix two issues here:

The recently opened urls where not saved
Semms that in KUrlRequester's open dialog you could only select files and not folders. You could stil select folders by typing their name in in text area of KUrlRequester but not through the dialog. So I just added appropriate buttons to open a QFileDialog in which you could select either folders or folders dependinf on the clicked button.

PS: Seems that there is not much activity in the project and I wasn't sure who I should add for reviewing, so I just added the last two committers in git :)

BUG: 346249
BUG: 365034

Test Plan

In general seems to work.

Screenshots of the Files Page

before

after

Diff Detail

Repository

R454 Kompare

Lint

Lint Skipped

Unit

Unit Tests Skipped

jsalatas created this revision.Mar 17 2017, 8:05 AM

kkofler added a reviewer: kkofler.Mar 18 2017, 9:29 AM

I am still the maintainer, though to be honest, I haven't done much to Kompare lately.

kkofler edited the summary of this revision. (Show Details)Mar 18 2017, 9:39 AM

Well, my first nitpick is that you are fixing 2 separate bugs and so should be submitting 2 separate code reviews.

In D5075#95809, @kkofler wrote:

Well, my first nitpick is that you are fixing 2 separate bugs and so should be submitting 2 separate code reviews.

Sure! I'll abandon this review and create two different ones.

I actually missed these bugs at first place! Thanks for mentioning!

jsalatas abandoned this revision.Mar 18 2017, 9:46 AM

Revision Contents
Changeset List

			Path	Packages
M			kompareurldialog.h (5 lines)
M			kompareurldialog.cpp (18 lines)
M			libdialogpages/filespage.h (6 lines)
M			libdialogpages/filespage.cpp (99 lines)
M			main.cpp (4 lines)