[KCModuleProxy] Remove dead code
ClosedPublic

Authored by broulik on Mar 15 2017, 2:47 PM.

Details

Summary

We don't want GUI stuff run as root, we have PolicyKit, there's no "rootInfo" anywhere anymore.
More importantly, this empty if condition would use KUser and then not do anything afterwards.

Test Plan

Still works.

(btw is there no "KDE Frameworks" Reviewer group like there is "Plasma"? I just end up adding dfaure directly all the time which makes me feel bad)

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 15 2017, 2:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 15 2017, 2:47 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript

There is "Frameworks", which is added as subscriber (not reviewer), but that's enough to have the email landing on kde-frameworks-devel (which is how I saw this review).

dfaure accepted this revision.Mar 29 2017, 6:44 AM

I don't know anything about this code, but if it's dead, it's dead.

This revision is now accepted and ready to land.Mar 29 2017, 6:44 AM
This revision was automatically updated to reflect the committed changes.