We don't want GUI stuff run as root, we have PolicyKit, there's no "rootInfo" anywhere anymore.
More importantly, this empty if condition would use KUser and then not do anything afterwards.
Details
Details
- Reviewers
dfaure - Commits
- R295:70c2485b2684: [KCModuleProxy] Remove dead code
Still works.
(btw is there no "KDE Frameworks" Reviewer group like there is "Plasma"? I just end up adding dfaure directly all the time which makes me feel bad)
Diff Detail
Diff Detail
- Repository
- R295 KCMUtils
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
There is "Frameworks", which is added as subscriber (not reviewer), but that's enough to have the email landing on kde-frameworks-devel (which is how I saw this review).