info from documentation
Any app.desktop with Type=Application needs an appdata file?
In this repo that would be simond, afaras, ksimond, sam, scc and sccd
Details
Details
- Reviewers
fux mak - Commits
- R431:78f289332e5a: add appdata.xml file for Simon
appstreamcli validate simon/org.kde.simon.appdata.xml -> no errors
Diff Detail
Diff Detail
- Repository
- R431 Simon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Any app.desktop with Type=Application needs an appdata file?
In this repo that would be simond, afaras, ksimond, sam, scc and sccd
Are all of them installed into /usr/share/applications? In general, only the apps you want users to see in software centers need a metainfo file.
You can hide apps in /usr/share/applications from AppStream-data processing tools by adding a X-AppStream-Ignore=true field to the .desktop file.
The file above isn't installed, it should be installed into ${KDE_INSTALL_METAINFODIR} (/usr/share/metainfo)
| simon/org.kde.simon.appdata.xml | ||
|---|---|---|
| 3 | Use "desktop-application" as component-type, to be more modern ;-) | |
| 5 | Ideally use FSFAP here, unless the project already uses CC0 somewhere, since CC0 requires you to include the license text with the sources, while FSFAP doesn't. | |
Comment Actions
Afaik all desktop files simond, afaras, ksimond, sam, scc and sccd are installed to $KDEDIR/share/applications.
Let Mario decide which apps should users see in software centers
Thanks for review
Comment Actions
I thought a bit about this and think that only simon itself should be visible in the software centers. The other apps are quite special, mostly packaged together and will most probably not be ported to KF5. Otherwise looks good and please commit.
Comment Actions
Hmm, for some weird reason the diff is the same as before...
In order to have the AppStream metadata generator ignore .desktop files that are in /usr/share/applications/ you must add an X-AppStream-Ignore=true field to them (likely to all except for the org.kde.simon.desktop one).
Otherwise, the other .desktop files might show up in software centers as well.
Comment Actions
Fix issues spotted by Matthias (use desktop-application as component-type and FSFAP as project_license)
upload corrected diff, sorry screwed it up :(
add X-AppStream-Ignore=true to simond, afaras, ksimond, sam, scc and sccd desktop files