Differential D5050

Increase the margins in ActionButtons
ClosedPublic
Actions

Authored by apol on Mar 14 2017, 3:19 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:dbd0e833e801: Increase the margins in ActionButtons
Summary

See https://phabricator.kde.org/M93/300/

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mar 14 2017, 3:19 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 14 2017, 3:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested changes to this revision.Mar 16 2017, 12:38 PM
mart added a subscriber: mart.
mart added inline comments.
src/controls/private/ActionButton.qml
49

button.x is assigned in many other places, it would break this binding

This revision now requires changes to proceed.Mar 16 2017, 12:38 PM
apol updated this revision to Diff 12514.Mar 16 2017, 12:41 PM
apol edited edge metadata.

addressed

apol marked an inline comment as done.Mar 16 2017, 12:42 PM
mart accepted this revision.Mar 16 2017, 12:43 PM
This revision is now accepted and ready to land.Mar 16 2017, 12:43 PM
Closed by commit R169:dbd0e833e801: Increase the margins in ActionButtons (authored by apol). · Explain WhyMar 16 2017, 12:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12515

View Options

src/controls/private/ActionButton.qml

Loading...
View Options

src/controls/private/PageActionPropertyGroup.qml

Loading...