new logout effect
ClosedPublic

Authored by mart on Mar 14 2017, 12:34 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:a7b7ce9ec07a: new logout effect
Summary

new logout effect: it's just a slow fade in of the logout
greeter (window is usable immediately tough

Test Plan

logout greeter now fades in without setting the window opacity manually

Diff Detail

Repository
R108 KWin
Branch
phab/logouteffect
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 14 2017, 12:34 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 14 2017, 12:34 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
broulik added inline comments.
effects/logout/package/contents/code/main.js
24

Connect to configurationChanged and update that time then (done in all other effects)

graesslin requested changes to this revision.Mar 14 2017, 5:00 PM

When adding a new effect the auto tests for the effect loader need to be adjusted as otherwise it fails because it finds effects it doesn't know of.

This revision now requires changes to proceed.Mar 14 2017, 5:00 PM

Please do not delete the shaders! They are still used by the blur effect for cheap fullscreen blur!

effects/logout/package/contents/code/main.js
28

is the window class still ksmserver given that we start a dedicated binary nowadays?

mart added a comment.Mar 15 2017, 11:15 AM

Please do not delete the shaders! They are still used by the blur effect for cheap fullscreen blur!

ouch, didn't knew, sorry :(perhaps would be better to move them in like a sharedshaders folder, so it's more self-evident it's not a leftover?

mart updated this revision to Diff 12487.Mar 15 2017, 11:54 AM
mart edited edge metadata.

add logout in tests

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptMar 15 2017, 11:54 AM
In D5045#95099, @mart wrote:

Please do not delete the shaders! They are still used by the blur effect for cheap fullscreen blur!

ouch, didn't knew, sorry :(perhaps would be better to move them in like a sharedshaders folder, so it's more self-evident it's not a leftover?

yes, maybe. I considered it a "useless" exercise back then, especially as we don't have a shared folder in the effects yet. So lots of moving code around for no big gain.

graesslin accepted this revision.Mar 15 2017, 3:51 PM
This revision is now accepted and ready to land.Mar 15 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.