Differential D4999

[FrameSvg] Ensure prefix list is never empty
AbandonedPublic
Actions

Authored by broulik on Mar 10 2017, 9:47 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

When setting an empty QStringList as prefix, it can lead to unexpected results, such as the prefix not changing.

BUG: 377441

Test Plan

See D4998 which shows a place where this happened

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 10 2017, 9:47 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 10 2017, 9:47 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Mar 10 2017, 9:51 AM

Wrote https://phabricator.kde.org/D5000 based on what you said in the other phab, the advantage there is you don't change what prefixes() returns.

broulik abandoned this revision.Mar 10 2017, 9:52 AM

I like yours better

Revision Contents
Changeset List

Diff 12352

View Options

src/declarativeimports/core/framesvgitem.cpp

Loading...