[Folder View] Explicitly set prefix as empty in normal state
ClosedPublic

Authored by broulik on Mar 10 2017, 9:38 AM.

Details

Summary

Somehow with FrameSvg optimizations State no longer manages to reset the property back to its original state when state is reset.

BUG: 377441
FIXED-IN: 5.9.4

Test Plan

Probably a Frameworks regression but I don't exactly know why it makes a difference. If setPrefix disregarded a change request (perhaps the old prefixes is {""} and then you set it to "" which is the same) it should do so in both cases?

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 10 2017, 9:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2017, 9:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

The difference is that when State resets the property, it uses the actual QStringList it had in there before and then uses that one. However, it is empty and then applyPrefixes doesn't do anything.

hein accepted this revision.Mar 10 2017, 1:38 PM
This revision is now accepted and ready to land.Mar 10 2017, 1:38 PM
This revision was automatically updated to reflect the committed changes.