Differential D4998

[Folder View] Explicitly set prefix as empty in normal state
ClosedPublic
Actions

Authored by broulik on Mar 10 2017, 9:38 AM.

Details

Reviewers

hein

Group Reviewers

Plasma

Commits

R119:b7ce1a4bc1d0: [Folder View] Explicitly set prefix as empty in normal state

Summary

Somehow with FrameSvg optimizations State no longer manages to reset the property back to its original state when state is reset.

BUG: 377441
FIXED-IN: 5.9.4

Test Plan

Probably a Frameworks regression but I don't exactly know why it makes a difference. If setPrefix disregarded a change request (perhaps the old prefixes is {""} and then you set it to "" which is the same) it should do so in both cases?

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Mar 10 2017, 9:38 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2017, 9:38 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

The difference is that when State resets the property, it uses the actual QStringList it had in there before and then uses that one. However, it is empty and then applyPrefixes doesn't do anything.

broulik mentioned this in D4999: [FrameSvg] Ensure prefix list is never empty.Mar 10 2017, 9:47 AM

hein accepted this revision.Mar 10 2017, 1:38 PM

This revision is now accepted and ready to land.Mar 10 2017, 1:38 PM

Closed by commit R119:b7ce1a4bc1d0: [Folder View] Explicitly set prefix as empty in normal state (authored by broulik). · Explain WhyMar 10 2017, 1:43 PM

This revision was automatically updated to reflect the committed changes.